Nullable Custom Resource ResponseURL#455
Merged
talenfisher merged 2 commits intomasterfrom Nov 18, 2021
Merged
Conversation
Member
talenfisher
commented
Nov 18, 2021
talenfisher
commented
- ResponseURL is now an optional argument to custom resource requests, to allow for easier testing.
- The lambda output for Custom Resources is now the full response that would've been sent to CloudFormation, rather than just the output data
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 93.28% 93.29% +0.01%
==========================================
Files 42 42
Lines 625 626 +1
==========================================
+ Hits 583 584 +1
Misses 42 42
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.